v1.16: Bump and unpin tokio (backport of #32430) #32909
Conversation
* Bump tokio to current, and unpin * Remove patch since ntapi is not longer in tree (cherry picked from commit c020211)
andreisilviudragnea
force-pushed
the
backport-32430
branch
from
63fcde4 to
1aeb454
Compare
|
Hello. Could you take a look at this PR? It is a blocker for us at the moment, as we need to downgrade our dependencies in order to upgrade from Solana v.1.14 to v1.16 on devnet. A new Solana v1.16 release is needed after this PR is merged. |
| @@ -380,7 +380,7 @@ tempfile = "3.5.0" | |||
| test-case = "2.2.2" | |||
| thiserror = "1.0.40" | |||
| tiny-bip39 = "0.8.2" | |||
| tokio = "~1.14.1" | |||
| tokio = "1.29.1" | |||
There was a problem hiding this comment.
It's too risky for us to upgrade the tokio dependency like this. We'd want the lockfile to keep tokio at 1.14.1 for the purposes of the entire v1.16 code base. But how about changing to tokio = "1" in the client/ crate? This should still enable the build to select 1.14.1 from the workspace lockfile, and when the next solana-client crate is published, the crates.io-dependency would revert back to tokio = "1" and be consistent with the tokio dependency in the v1.14 version of the client crate
There was a problem hiding this comment.
maybe #32879 in v1.16 only. I don't think it's necessary in master
There was a problem hiding this comment.
for master we can just upgrade tokio directly to the newest crate if that works
|
Closing this in favour of #32943 |
Problem
Tokio version specifier
"~1.14.1"only allows patch updates and v1.14.1 is more than a year old.Summary of Changes
Backport of #32430
Fixes #32878